Update node to latest LTS (#1687)
authorKrishan <33421343+kfiven@users.noreply.github.com>
Wed, 24 Apr 2024 14:31:01 +0000 (00:31 +1000)
committerGitHub <noreply@github.com>
Wed, 24 Apr 2024 14:31:01 +0000 (00:31 +1000)
* Update node to latest LTS

* Update node in Dockerfile

.github/workflows/build-pull-request.yml
.github/workflows/netlify-dev.yml
.github/workflows/prod-deploy.yml
Dockerfile
README.md

index f2f93feb446e789b36a346b00b040cd4cbb3de63..5346a762f4f9a62deeefcd5212ca86dca86a8343 100644 (file)
@@ -16,13 +16,13 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v3.8.1
         with:
-          node-version: 18.12.1
-          cache: "npm"
+          node-version: 20.12.2
+          cache: 'npm'
       - name: Install dependencies
         run: npm ci
       - name: Build app
         env:
-          NODE_OPTIONS: "--max_old_space_size=4096"
+          NODE_OPTIONS: '--max_old_space_size=4096'
         run: npm run build
       - name: Upload artifact
         uses: actions/upload-artifact@v3.1.2
index 411b6e3e3539d2e52814aad94c85678b3c84c65c..c3de8811c8ba0048caa1041470f356eb9da344dd 100644 (file)
@@ -3,7 +3,7 @@ name: Deploy to Netlify (dev)
 on:
   push:
     branches:
-       - dev
+      - dev
 
 jobs:
   deploy-to-netlify:
@@ -15,19 +15,19 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v3.8.1
         with:
-          node-version: 18.12.1
-          cache: "npm"
+          node-version: 20.12.2
+          cache: 'npm'
       - name: Install dependencies
         run: npm ci
       - name: Build app
         env:
-          NODE_OPTIONS: "--max_old_space_size=4096"
+          NODE_OPTIONS: '--max_old_space_size=4096'
         run: npm run build
       - name: Deploy to Netlify
         uses: nwtgck/actions-netlify@7a92f00dde8c92a5a9e8385ec2919775f7647352
         with:
           publish-dir: dist
-          deploy-message: "Dev deploy ${{ github.sha }}"
+          deploy-message: 'Dev deploy ${{ github.sha }}'
           enable-commit-comment: false
           github-token: ${{ secrets.GITHUB_TOKEN }}
           production-deploy: true
index 63fc342c9a8f3df5bfb74dc4f826893701d01c7a..83e6ed8f7ec8b9b774e867ba8c2f519c50dbb1db 100644 (file)
@@ -14,19 +14,19 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v3.8.1
         with:
-          node-version: 18.12.1
-          cache: "npm"
+          node-version: 20.12.2
+          cache: 'npm'
       - name: Install dependencies
         run: npm ci
       - name: Build app
         env:
-          NODE_OPTIONS: "--max_old_space_size=4096"
+          NODE_OPTIONS: '--max_old_space_size=4096'
         run: npm run build
       - name: Deploy to Netlify
         uses: nwtgck/actions-netlify@7a92f00dde8c92a5a9e8385ec2919775f7647352
         with:
           publish-dir: dist
-          deploy-message: "Prod deploy ${{ github.ref_name }}"
+          deploy-message: 'Prod deploy ${{ github.ref_name }}'
           enable-commit-comment: false
           github-token: ${{ secrets.GITHUB_TOKEN }}
           production-deploy: true
index da04492cdaef5f7fd6b08e32b570f07d153ff490..b0d2a93568ef61ed23b362d3ad3ec4a554f44e54 100644 (file)
@@ -1,5 +1,5 @@
 ## Builder
-FROM node:18.12.1-alpine3.15 as builder
+FROM node:20.12.2-alpine3.18 as builder
 
 WORKDIR /src
 
index 0910dfbb2fef9627ee47f31ecd697db13366ccc8..0fc928b6ee54433a12a2ad195ca2b5c49a96519d 100644 (file)
--- a/README.md
+++ b/README.md
@@ -86,7 +86,7 @@ UeGsouhyuITLwEhScounZDqop+Dx
 
 ## Local development
 > We recommend using a version manager as versions change very quickly. You will likely need to switch 
-between multiple Node.js versions based on the needs of different projects you're working on. [NVM on windows](https://github.com/coreybutler/nvm-windows#installation--upgrades) on Windows and [nvm](https://github.com/nvm-sh/nvm) on Linux/macOS are pretty good choices. Also recommended nodejs version Hydrogen LTS (v18).
+between multiple Node.js versions based on the needs of different projects you're working on. [NVM on windows](https://github.com/coreybutler/nvm-windows#installation--upgrades) on Windows and [nvm](https://github.com/nvm-sh/nvm) on Linux/macOS are pretty good choices. Recommended nodejs version is Iron LTS (v20).
 
 Execute the following commands to start a development server:
 ```sh